-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UHF-9588: Unit search variant fixes #917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e missing translation
3 tasks
3 tasks
…l button styling change
…file, added styles for health station and maternity clinic searches as well
…ce for district and project search advanced filters wrapper
…dbt into UHF-9588
…ps, add translations for these strings
juho-lehmonen
suggested changes
Mar 11, 2024
✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/917/html_report/ |
juho-lehmonen
approved these changes
Mar 11, 2024
This was referenced Mar 11, 2024
This was referenced Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
recreate-reference-images
Use this label to re-create reference images used by Visual regression tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UHF-9588
What was done
How to install
git pull origin dev
make fresh
OR
git pull origin UHF-9588
make fresh
composer require drupal/hdbt:dev-UHF-9588
make drush-locale-update drush-cr
How to test
hdbt-search__selections-wrapper
has height of 0px when there is no selections made on the form. If you add some search parameters and click Search the tags should appear below the submit button as before but now the element is not taking space there constantly. Also the submit button value should now be Search/Etsi/Sök.hdbt-search--react__submit-button
and no more hds-classes and it should be a bit bigger longer than it was before (280px to be exact)hdbt-search__selections-wrapper
has height of 0px when there is no selections made on the form.hdbt-search__selections-wrapper
has height of 0px when there is no selections made on the form.Designers review
Other PRs