Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9588: Unit search variant fixes #917

Merged
merged 15 commits into from
Mar 11, 2024
Merged

UHF-9588: Unit search variant fixes #917

merged 15 commits into from
Mar 11, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Mar 6, 2024

UHF-9588

What was done

  • Change search buttons translation to correct one
  • Add one missing translation
  • Change job search submit button class to correct one.
  • Hide the clear all button when there is no content tags.
  • Add small style changes.
  • Add contexts to react app strings that didn't have it before.
  • Add corresponding translations.

How to install

  • This PR should be checked with KYMP, REKRY, KASKO and ETUSIVU instances. For KYMP and REKRY checkout the feature branch - others make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
      OR
    • git pull origin UHF-9588
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9588
  • Run make drush-locale-update drush-cr

How to test

  • For KYMP go to https://helfi-kymp.docker.so/fi/kaupunkiymparisto-ja-liikenne/kaupunkisuunnittelu-ja-rakentaminen/suunnitelmat-ja-rakennushankkeet and make sure that the hdbt-search__selections-wrapper has height of 0px when there is no selections made on the form. If you add some search parameters and click Search the tags should appear below the submit button as before but now the element is not taking space there constantly. Also the submit button value should now be Search/Etsi/Sök.
  • For REKRY go to https://helfi-rekry.docker.so/fi/avoimet-tyopaikat/etsi-avoimia-tyopaikkoja make sure that there is the same gap as in the above. In addition the submit button should now have the class hdbt-search--react__submit-button and no more hds-classes and it should be a bit bigger longer than it was before (280px to be exact)
  • For KASKO go to https://helfi-kasko.docker.so/fi/kasvatus-ja-koulutus/perusopetus/peruskoulut and switch to the second tab "Etsi koulun tiedoilla". Here the submit button should have 32px gap on top to the dropdowns and the hdbt-search__selections-wrapper has height of 0px when there is no selections made on the form.
  • For ETUSIVU go to https://helfi-etusivu.docker.so/fi/uutiset and check that the hdbt-search__selections-wrapper has height of 0px when there is no selections made on the form.
  • Next we need to check the events search changes. You can for example add the events search to some basic page with the values suggested in the paragraph help texts and save. The events search should now have submit button value as Search/Etsi/Sök and the button should be the same size as for example in the jobs search (280px to be exact)
  • Check that translations on all react apps are still visible after adding contexts to the strings that were missing it.
  • Check that code follows our standards

Designers review

  • This PR has been visually reviewed by a designer (Nina Hiukkanen)

Other PRs

@teroelonen teroelonen marked this pull request as ready for review March 7, 2024 13:02
@teroelonen teroelonen added the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Mar 7, 2024
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/917/html_report/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
recreate-reference-images Use this label to re-create reference images used by Visual regression tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants