Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9576 linked events keywords #920

Merged
merged 5 commits into from
Mar 15, 2024
Merged

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Mar 11, 2024

UHF-9576

What was done

  • Add keyword filter to event_list paragraph.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9530-linked-events-keywords
    • composer require drupal/helfi_platform_config:dev-UHF-9576-linked-events-keywords
  • Run make drush-updb drush-cr
  • Update translations: drush locale:check && drush locale:update; drush cr.

How to test

  • Run drush mim linked_events_keywords --reset-threshold 1
  • Check that event list paragraph works with the new features

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

@hyrsky hyrsky marked this pull request as draft March 11, 2024 09:20
@hyrsky
Copy link
Contributor Author

hyrsky commented Mar 11, 2024

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works nicely. Needs translations but otherwise perfert!

@hyrsky hyrsky force-pushed the UHF-9530-linked-events-keywords branch from eb5efa3 to 795534e Compare March 14, 2024 06:16
@hyrsky hyrsky changed the title UHF-9530 linked events keywords UHF-9576 linked events keywords Mar 14, 2024
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/920/html_report/

@hyrsky
Copy link
Contributor Author

hyrsky commented Mar 15, 2024

This works nicely. Needs translations but otherwise perfert!

Translations were added here: City-of-Helsinki/drupal-helfi-platform-config#712 and this was approved by Juho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants