Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9791: UHF-9791: Refactor javascript code to be more readable #936

Merged
merged 13 commits into from
Apr 4, 2024
Merged

UHF-9791: UHF-9791: Refactor javascript code to be more readable #936

merged 13 commits into from
Apr 4, 2024

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Apr 2, 2024 •
edited by jira bot
Loading

UHF-9791

  • Code needed some refactoring

What was done

  • Code was refactored

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9791_clean_code
  • Run make drush-cr

How to test

  • Check that cookie banner works as it should
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Arkkimaagi added 10 commits April 2, 2024 11:53
@Arkkimaagi
UHF-9791: UHF-9791: Refactor javascript code to be more readable
824404a
@Arkkimaagi
UHF-9791: UHF-9791: Handle race condidition on document loading better.
df4e8c9
@Arkkimaagi
UHF-9791: UHF-9791: Move initiatilizing to HTML and convert options t…
765bd1d 
…o parameters from global scope
@Arkkimaagi
UHF-9791: UHF-9791: Fix chat API function to be non-async and get rid…
2f19045 
… of the event to update checkboxes
@Arkkimaagi
UHF-9791: UHF-9791: Make class methods and properties private, remove…
948aa5e 
… expose-chat-functions
@Arkkimaagi
UHF-9791: UHF-9791: Support SPA approach with closeable banner and tr…
be3c19b 
…iggered events
@Arkkimaagi
UHF-9791: UHF-9791: Add JsDoc
069bb09
@Arkkimaagi
UHF-9791: UHF-9791: Announce saving of the settings to screen readers…
b980968 
… when in React mode
@Arkkimaagi
UHF-9791: UHF-9791: Support strings in hds-cc_translations.js
5001a49
@Arkkimaagi
UHF-9791: UHF-9791: Add missing jsdocs
07b9172
@Arkkimaagi Arkkimaagi marked this pull request as ready for review April 4, 2024 09:08
j-mys
j-mys reviewed Apr 4, 2024
View reviewed changes
src/js/hds-cc/hds-cc.js Outdated Show resolved Hide resolved
j-mys
j-mys reviewed Apr 4, 2024
View reviewed changes
src/js/hds-cc/hds-cc.js Outdated Show resolved Hide resolved
j-mys
j-mys reviewed Apr 4, 2024
View reviewed changes
src/js/hds-cc/hds-cc.js Outdated Show resolved Hide resolved
j-mys
j-mys reviewed Apr 4, 2024
View reviewed changes
src/js/hds-cc/hds-cc.js Outdated Show resolved Hide resolved
j-mys
j-mys approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@j-mys j-mys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/936/html_report/

@Arkkimaagi Arkkimaagi merged commit 9217f92 into UHF-9675_cookie_banner Apr 4, 2024
1 of 2 checks passed
@Arkkimaagi Arkkimaagi deleted the UHF-9791_clean_code branch April 4, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-mys j-mys j-mys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkkimaagi @j-mys