Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9786: Fix missing links #942

Merged
merged 2 commits into from
Apr 5, 2024
Merged

UHF-9786: Fix missing links #942

merged 2 commits into from
Apr 5, 2024

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Apr 5, 2024

UHF-9786

The links are not appearing without also defining extra information text.

For example this Kymp page has links in Finnish and Swedish, but only Finnish has extra information text and only that accordion is visible:
image
image

What was done

  • The twig template if-statement was modified to check the actual content of the accordion, thus making the links visible even without the extra information text.

image

How to install

  • Make sure your instance (KYMP) is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9786_missing_links
  • Run make drush-cr

How to test

  • Check that this local page has the links (and accordion) visible as in above screenshot.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Copy link

github-actions bot commented Apr 5, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/942/html_report/

Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work correctly 🦖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants