Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9738: news article content type #945

Merged
merged 2 commits into from
Apr 11, 2024
Merged

UHF-9738: news article content type #945

merged 2 commits into from
Apr 11, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Apr 10, 2024

UHF-9738

What was done

  • Separate hero to a reusable template so that we can render it on news articles as well.
  • Separate news footer elements to a reusable template so that news items and news articles both can use it without duplicating code.

How to install

  • Check testing instructions from the front page instance PR.

How to test

  • Check testing instructions from the front page instance PR.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/945/html_report/

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job of extending the existing templates. 👍 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants