Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9348: Add fix for image-placeholder size on content cards paragraph #966

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Apr 18, 2024

UHF-9348

What was done

  • Changed the image placeholder aspect ratio on content cards paragraph.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9348
  • Run make drush-cr

How to test

  • Go to add a new page and add content cards paragraph for it on any instance you like.
  • Add two content references for the paragraph and make sure the other one doesn't have the liftup image and other one has.
  • The placeholder image and the real image should be now in the same aspect ratio and so the same height. Previously the image placeholder was smaller.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/966/html_report/

@teroelonen teroelonen added the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Apr 18, 2024
@teroelonen teroelonen marked this pull request as ready for review April 18, 2024 09:21
@tuutti tuutti removed the recreate-reference-images Use this label to re-create reference images used by Visual regression tests label Apr 18, 2024
Copy link

✅ Tests passed! You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/966/html_report/

@juho-lehmonen juho-lehmonen self-requested a review April 18, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants