Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-9485 cookie sniffing #974

Merged
merged 11 commits into from
May 16, 2024
Merged

UHF-9485 cookie sniffing #974

merged 11 commits into from
May 16, 2024

Conversation

Arkkimaagi
Copy link
Contributor

@Arkkimaagi Arkkimaagi commented Apr 23, 2024 •
edited by jira bot
Loading

UHF-9485

What was done

  • This thing was fixed

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9485_cookie_sniffing
  • Run make drush-cr

How to test

  • Check that this feature works
  • Check that code follows our standards

@Arkkimaagi Arkkimaagi changed the base branch from main to UHF-9675_cookie_banner April 23, 2024 09:40
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/974/html_report/

j-mys
j-mys approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@j-mys j-mys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is clean and readable, functionality works in browser

@Arkkimaagi Arkkimaagi marked this pull request as ready for review May 16, 2024 05:49
@Arkkimaagi Arkkimaagi merged commit 60de521 into UHF-9675_cookie_banner May 16, 2024
1 of 2 checks passed
@Arkkimaagi Arkkimaagi deleted the UHF-9485_cookie_sniffing branch May 16, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-mys j-mys j-mys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkkimaagi @j-mys