Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9796 cookie banner cleanup #989

Merged
merged 6 commits into from
May 24, 2024
Merged

Conversation

Arkkimaagi
Copy link
Contributor

UHF-0000

What was done

  • This thing was fixed

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-0000_insert_correct_branch
  • Run make drush-cr

How to test

  • Check that this feature works
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

  • Link to other PR

@Arkkimaagi Arkkimaagi changed the title Uhf 9796 cleanup UHF-9796 cookie banner cleanup May 16, 2024
@Arkkimaagi Arkkimaagi changed the base branch from main to UHF-9675_cookie_banner May 16, 2024 11:21
Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt/pull/989/html_report/

@Arkkimaagi Arkkimaagi marked this pull request as ready for review May 24, 2024 05:27
@Arkkimaagi Arkkimaagi merged commit 98bd584 into UHF-9675_cookie_banner May 24, 2024
1 of 2 checks passed
@Arkkimaagi Arkkimaagi deleted the UHF-9796_cleanup branch May 24, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants