Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11176: Add addresslabel param to kartta.hel.fi links #807

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

jeremysteerio
Copy link
Contributor

@jeremysteerio jeremysteerio commented Dec 18, 2024

UHF-11176

Add adresslabel param to links to provide better info to user.

What was done

  • Add addresslabel param to external links in Helsinki near you services block
  • Add translations
  • Fix existing typo in translations
  • Fix kartta.hel.fi link hashes (old ones contained pin of a random address)

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout origin/11176
    • make fresh
  • Run make drush-cr

How to test

  • Go to Helsinki near you results page, eg. https://helfi-etusivu.docker.so/fi/helsinki-lahellasi/tulokset?q=Heteniityntie%2B4
  • Follow the external links (ending in "... on map") to kartta.hel.fi
  • Check that the displayed shows data you'd expect to see (map loading might take a long time)
  • You should see a blue pin in the middle of the map. On the right bottom corner, in the "On the map now" infobox, you should see label for the pin corresponding to the addresslabel query param passed in the url. Disclaimer: The map seems to inconsistently load the with the pin in the middle. A reload usually works.
  • Check that code is up to our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

@jeremysteerio jeremysteerio marked this pull request as ready for review December 18, 2024 13:38
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 🦖

@jeremysteerio jeremysteerio merged commit 73e8e7e into dev Dec 19, 2024
3 checks passed
@jeremysteerio jeremysteerio deleted the UHF-11176 branch December 19, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants