Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9132: Add max-width limitation to all content types without sidebar except landing page #734

Merged
merged 8 commits into from
Dec 1, 2023

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Nov 23, 2023

UHF-9132

What was done

  • KYMP specific changes for the limit to the component--upper region of max-width 860px.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-9132
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-9132
    • make fresh
  • Run make drush-cr

How to test

  • Check testing instructions from the hdbt PR.
  • Check that code follows our standards

Designers review

  • This PR does not need designers review
  • This PR has been visually reviewed by a designer (Name of the designer)

Other PRs

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with this! 💪 🚀

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teroelonen teroelonen merged commit 8afe424 into dev Dec 1, 2023
3 checks passed
@teroelonen teroelonen deleted the UHF-9132 branch December 1, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants