Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-10887 Hearings #866

Merged
merged 2 commits into from
Dec 13, 2024
Merged

UHF-10887 Hearings #866

merged 2 commits into from
Dec 13, 2024

Conversation

rpnykanen
Copy link
Contributor

@rpnykanen rpnykanen commented Dec 12, 2024

UHF-10887

Updated the hearing logic and removed code which is now obsolete.

Show only hearings with correct translation on the listing.
The old implementation tried it's best to show same amount of hearings for all translations. For example, if there were 3 finnish hearings but only 2 swedish, it would have shown 2 swedish and 1 finnish hearings.

A hearing paragraph can be found from strategia for example: strategia test or etusivu frontpage

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi packages
    • composer require drupal/helfi_platform_config:dev-UHF-10887
    • composer require drupal/hdbt:dev-UHF-10887
  • Run make drush-updb drush-cr

How to test

  • Go to a page with hearings block on finnish language
    • At this moment there should be 2 finnish hearings visible
  • Change language to swedish
    • There should be 1 visible hearing (instead of 1 finnish and 1 swedish)
  • On english page, there should be no visible hearings (instead of 2 finnish)

Related PRs

City-of-Helsinki/drupal-hdbt#1137

Copy link

sonarcloud bot commented Dec 12, 2024

@rpnykanen rpnykanen changed the title UHF-10887 UHF-10887 Hearings Dec 12, 2024
@juho-lehmonen juho-lehmonen self-requested a review December 12, 2024 13:36
Copy link
Contributor

@juho-lehmonen juho-lehmonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as intended otherwise, but the "x hearings open for commenting" label shows "2" on the swedish version, even though there's only one hearing open for that language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants