feat: hide all information_system attributes from es search (#415)

Previously we restricted the information system from basic filters and
views for unauthenticated users.
This adds hiding the InformationSystem attribues from unauthenticated
users in elastic backed searches as well.

Refs TIED-171

search_indices/serializers/base.py

@@ -30,5 +30,10 @@ class Meta:
     def get_score(self, obj: Hit) -> int:
         return obj.meta.score
 
+    @property
+    def is_authenticated(self):
+        request = self.context.get("request")
+        return bool(request and request.user.is_authenticated)
+
     def get_attributes(self, obj: Hit) -> Optional[dict]:
-        return get_attributes(obj, "attributes")
+        return get_attributes(obj, "attributes", self.is_authenticated)

search_indices/serializers/utils.py

@@ -2,8 +2,18 @@
 
 from elasticsearch_dsl.response.hit import Hit
 
+attributes_for_authenticated = (
+    "function_InformationSystem",
+    "action_InformationSystem",
+    "classification_InformationSystem",
+    "record_InformationSystem",
+    "phase_InformationSystem",
+)
 
-def get_attributes(obj: Hit, attribute_field_name: str) -> Optional[dict]:
+
+def get_attributes(
+    obj: Hit, attribute_field_name: str, authenticated: bool
+) -> Optional[dict]:
     """
     Fetch attributes from index and revert the attribute names that
     have "." replaced with "+".
@@ -14,6 +24,11 @@ def get_attributes(obj: Hit, attribute_field_name: str) -> Optional[dict]:
         attrs = attrs.to_dict()
         for key, value in attrs.items():
             key = key.replace("+", ".")
+
+            if not authenticated and key in attributes_for_authenticated:
+                continue
+
             attributes[key] = value
+
         return attributes
     return None

search_indices/tests/conftest.py

@@ -7,6 +7,7 @@
 from elasticsearch import Elasticsearch
 from elasticsearch_dsl.connections import add_connection
 from pytest import fixture
+from rest_framework.test import APIClient
 
 from metarecord.models import Action, Classification, Function, Phase, Record
 from metarecord.tests.conftest import user, user_api_client  # noqa
@@ -57,7 +58,7 @@ def destroy_indices():
     RecordDocument._index.delete(ignore=[400, 404])
 
 
-@fixture(scope="session", autouse=True)
+@fixture(scope="class", autouse=True)
 def create_indices():
     """
     Initialize all indices with the custom analyzers.
@@ -82,13 +83,25 @@ def es_connection():
     yield es_connection
 
 
+@fixture
+def api_client():
+    return APIClient()
+
+
 @fixture
 def action(phase):
     return Action.objects.create(
         attributes={"AdditionalInformation": "testisana"}, phase=phase, index=1
     )
 
 
+@fixture
+def action_with_information_system(phase):
+    return Action.objects.create(
+        attributes={"InformationSystem": "xyz"}, phase=phase, index=1
+    )
+
+
 @fixture
 def action_2(phase_2):
     return Action.objects.create(
@@ -124,6 +137,13 @@ def function(classification):
     )
 
 
+@fixture
+def function_with_information_system(classification_2):
+    return Function.objects.create(
+        attributes={"InformationSystem": "xyz"}, classification=classification_2
+    )
+
+
 @fixture
 def function_2(classification_2):
     return Function.objects.create(
@@ -139,6 +159,13 @@ def phase(function):
     )
 
 
+@fixture
+def phase_with_information_system(function):
+    return Phase.objects.create(
+        attributes={"InformationSystem": "xyz"}, function=function, index=1
+    )
+
+
 @fixture
 def phase_2(function_2):
     return Phase.objects.create(