Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting targetIdentifier if plan_unit falsy #450

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix getting targetIdentifier if plan_unit falsy #450

merged 1 commit into from
Dec 5, 2023

Conversation

henrinie-nc
Copy link
Contributor

Code seems to intend to pick target.custom_detailed_plan if target.plan_unit does not exist. The code failed on target.plan_unit being falsy, so couldn't get the identifier.

@henrinie-nc henrinie-nc requested review from NC-jsAhonen and a user December 4, 2023 13:38
ghost
ghost approved these changes Dec 5, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@henrinie-nc henrinie-nc merged commit 5ff23d6 into develop Dec 5, 2023
3 checks passed
@henrinie-nc henrinie-nc deleted the fix/1899-targetid-reservationlink branch December 5, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NC-jsAhonen NC-jsAhonen Awaiting requested review from NC-jsAhonen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@henrinie-nc