Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop to master #481

Merged
merged 69 commits into from
May 23, 2024
Merged

Develop to master #481

merged 69 commits into from
May 23, 2024

Conversation

henrinie-nc
Copy link
Contributor

No description provided.

henrinie-nc and others added 30 commits February 1, 2024 09:00
Setting NODE_ENV to development installs devDependencies,
which are required in build usually
- Reorganize packages to devDependencies when they belong there
- Update tons of build related packages
- Exclude FavIconsWebpackPlugin, it pulls some deps that don't seem to work sanely
- Refactor webpack configurations to match demands of newer versions
- Refactor webpack dev server config
- Update browserslist to latest (comes from babel)
…tions

Update node gh actions + build dependencies
- Makes no fields required
- Renames buttons to simply "save"
- Fixes issue when long list of status notes appear, they would not be scrollable, making the modals buttons appear outside of the screen
- Set default value for lessor, so that it can be clicked to edit when it is empty
- Allow saving null preparer, as previously you could not change preparer to null (requires change to backend to allow null value)
It would attempt to mark e.g. trade register check to all the applicants applications.
This behavior is not desired in area search.
…-application-form

Fix field types to render area search application form
NC-jsAhonen and others added 22 commits April 25, 2024 13:25
…tering-from-area-searches

remove default service unit filter from area search application list page
…ns-for-rent-adjustments

Fix adding subventions for newly added rent adjustments
…ns-for-rent-adjustments

fix checking changes in subventions
…it-lease-filter-out-of-detailed-search

move service unit filter to table filter component
Copy link
Contributor

@NC-jsAhonen NC-jsAhonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the tonttihaku and aluehaku hidden, and should they be?

@henrinie-nc
Copy link
Contributor Author

Are the tonttihaku and aluehaku hidden, and should they be?

@NC-jsAhonen
For production should be hidden, see #455

Copy link
Contributor

@NC-jsAhonen NC-jsAhonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SideMenu seems to have the hiding of the area and plot searches for production, so it's okay. Otherwise, it doesn't seem to me that any further fixes need to be done at this point.

@henrinie-nc henrinie-nc merged commit d2a79eb into master May 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants