Replace geocoder address search with servicemap #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NC-jsAhonen
approved these changes
Aug 2, 2024
| }); | ||
| const proto = 'https:'; | ||
| return `${proto}//dev.hel.fi/geocoder/v1/address/?${paramString}&municipality=91`; | ||
| return `https://api.hel.fi/servicemap/v2/search/?${paramString}&type=address&municipality=helsinki`; |
There was a problem hiding this comment.
Should we use SERVICE_MAP_URL in AddressSearchInput.tsx for this url as well?
There was a problem hiding this comment.
It could be moved somewhere like src/components/ or src/
There was a problem hiding this comment.
Well that is good to know, so we were already using this API for some other address search...
I wonder why this was not unified, perhaps the same issue - it was not known at the time?
There was a problem hiding this comment.
@NC-jsAhonen I have utilized SERVICE_MAP_URL now.
The whole thing should be cleaned out, but I will not do it now, discovered too late - lets get this out to be validated, once smaller issues within this code have been approved
Can't yet upgrade dependencies, therefore copied over types
henrinie-nc
force-pushed
the
MVJ-397-replace-geocoder
branch
from
0883128 to
1a422ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.