Mvj 536 map tool icons #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juho-kettunen-nc
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does to fix certain images for leaflet-draw, is that it copies the images of leaflet-draw to the build.
Since in current version of leaflet-draw its css points the images to
image/xxxbut vite wants them to be inassets, we will transform the cssurl()'s that start withimages/toassets/images/.If you know of a better way let me know. Would maybe prefer inline of the images base64 in the css or something, but not sure how to accomplish it with this specific library. Maybe it is not worth any extra time to spend more fighting it.
On top of this, I also changed some css
url()'s to point to/assets/instead of../assets- seems more correct and didn't see any issues with that. Those svg's seems to endup in the css files as inline in any case.