Improve typing in leases/helpers #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrinie-nc
approved these changes
Nov 1, 2024
juho-kettunen-nc
force-pushed
the
MVJ-312-archived-areas
branch
from
e1c8a7d to
dc3f422
Compare
|
Rebased over develop, to refresh the branch with last 3 weeks' changes. |
juho-kettunen-nc
force-pushed
the
MVJ-312-archived-areas
branch
from
dc3f422 to
5b37b84
Compare
juho-kettunen-nc
force-pushed
the
MVJ-312-archived-areas
branch
from
f7059f6 to
9cdc48b
Compare
|
Again rebased over develop |
juho-kettunen-nc
changed the title
|
This PR is no longer about ticket MVJ-312, because the ordering for LeaseArea and LeaseAreaAddress will be performed on the API side: City-of-Helsinki/mvj#790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, UI showed the first results of each that were unsorted by
backend. This meant that LeaseInfo could show area identifier and
address from an archived area, while unarchived areas would exist.
TODO: think with customer if feature should be implemented in backend instead, to align invoicing with UI.