-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MVJ-550 override_receivable_type in Rent (UI) #545
MVJ-550 override_receivable_type in Rent (UI) #545
Conversation
182ceae
to
e0a9654
Compare
Still requires customer blessing to use this Rent version instead of the ContractRent, but this is the best version of the logic we have right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems usable. Improvement might be to add an attribute to the service unit model to dictate whether to use override field for this service unit, so we would not need to hard code lists of ID's and define code with service unit names.
Check my comments on the changes before merging.
Added new field Input validation and tests in City-of-Helsinki/mvj@9e4c041 |
Looks good for the UI part! |
Reminder to self: squash, or rebase locally |
96e3d70
to
f825671
Compare
This implements the UI part of override receivable type, where it is a property of Rent, instead of ContractRent as in #544