Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rent tab: edit old_dwellings_in_housing_companies_price_index_type #554

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

NC-jsAhonen
Copy link
Contributor

Tasotarkistus type is now editable

@juho-kettunen-nc
Copy link
Contributor

Good progress! I however want to address the naming: the type field is not for index type. I don't think there exists multiple types for the index that would be available for choosing.

I see that the correct interpretation is already in place in docstring of the enum's "In Finnish"-section, which says that the enum is for "Tasotarkistuksen tyyppi". The name of the property would probably then be periodic_rent_adjustment_type, and enum PeriodicRentAdjustmentType.

@juho-kettunen-nc
Copy link
Contributor

juho-kettunen-nc commented Dec 11, 2024

But I know there is time pressure to show this to customer tomorrow, so I'll create a ticket about changing the name later this week (EDIT: on second thought, no hurry this week). This way we can get this merged and displayed tomorrow, as this does not affect what is shown in UI.

@NC-jsAhonen NC-jsAhonen merged commit f58808f into develop Dec 12, 2024
3 checks passed
@NC-jsAhonen NC-jsAhonen deleted the MVJ-421-edit-tasotarkistus-type branch December 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants