Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mvj 353 intendeduse per serviceunit #657

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

henrinie-nc
Copy link
Contributor

Adding filters to IntendedUseViewSet allows using the endpoint to get correct IntendedUse's in the UI from /intended_use/?service_unit=x

this allows filtering based on service_unit and name
…and lease.service_unit

This is implemented on model level in Lease.save() and in serializer validation
@henrinie-nc
Copy link
Contributor Author

@robertrytovuori I added one commit more, could you re-review that one bf70e77 ?
Now there is also the corresponding UI pull request: City-of-Helsinki/mvj-ui#489

Copy link
Contributor

@robertrytovuori robertrytovuori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice with the tests. All intendedUse seem to have reference to the same service_unit 1 in fixture but I'm guessing its supposed to be that way.

@henrinie-nc henrinie-nc merged commit bf70e77 into develop Jun 13, 2024
2 checks passed
@henrinie-nc henrinie-nc deleted the MVJ-353-intendeduse-per-serviceunit branch June 13, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants