Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mvj 542 intendeduse isactive filter #767

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

henrinie-nc
Copy link
Contributor

No description provided.

@henrinie-nc henrinie-nc force-pushed the MVJ-542-intendeduse-isactive-filter branch from a6ccb27 to 62bc13f Compare November 8, 2024 11:25
@juho-kettunen-nc
Copy link
Contributor

See my question on the UI PR, probably should have been posted here instead: City-of-Helsinki/mvj-ui#541 (comment)

I guess the UI change only touches the intended use select form element, which would make the summary page work as expected. But is it a problem for advanced search?

These commits were made after the daily where the new requirements were presented, so I guess these already take them into account, by removing the IntendedUseManager which removed all inactives.

@henrinie-nc
Copy link
Contributor Author

See my question on the UI PR, probably should have been posted here instead: City-of-Helsinki/mvj-ui#541 (comment)

I guess the UI change only touches the intended use select form element, which would make the summary page work as expected. But is it a problem for advanced search?

These commits were made after the daily where the new requirements were presented, so I guess these already take them into account, by removing the IntendedUseManager which removed all inactives.

API will (now) not do any filter unless the query parameter is provided, so on that end nothing should change. Admin will work completely normally, but it also has the ability to use is_active for filtering intended uses.

@henrinie-nc henrinie-nc merged commit 9b4f6ae into develop Nov 12, 2024
2 checks passed
@henrinie-nc henrinie-nc deleted the MVJ-542-intendeduse-isactive-filter branch November 12, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants