Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new ssn intermediary characters #463

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

voneiden
Copy link
Contributor

Ref HP-2087

@voneiden voneiden requested a review from a team December 27, 2023 08:25
@voneiden voneiden force-pushed the hp-2087-update-ssn-regex branch from 3df02ba to 247a10f Compare December 27, 2023 09:15
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d75eb2f) 91.25% compared to head (50fee1f) 91.25%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #463   +/-   ##
========================================
  Coverage    91.25%   91.25%           
========================================
  Files           55       55           
  Lines         2800     2800           
  Branches       329      329           
========================================
  Hits          2555     2555           
  Misses         189      189           
  Partials        56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@akikoskinen akikoskinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message could elaborate more what the change is about. Perhaps also a link to the population registry's news.

profiles/tests/test_models.py Outdated Show resolved Hide resolved
@voneiden voneiden force-pushed the hp-2087-update-ssn-regex branch 2 times, most recently from 0087602 to 0b0e935 Compare December 28, 2023 12:26
@voneiden voneiden requested a review from akikoskinen December 28, 2023 12:33
> New separators for the personal identity code introduced in December
> 2023
> Following the reform, the intermediate character used will be:
>
>    For those born in or after 2000, the current A or the new B, C, D,
     E, F.
>    For those born in the 20th century, the current hyphen (-) or the
     new letters Y, X, W, V, U.
>    For those born in the 19th century, the current plus sign (+) – no
     new intermediate characters will be introduced for such cases.
@voneiden voneiden force-pushed the hp-2087-update-ssn-regex branch from 0b0e935 to 50fee1f Compare December 29, 2023 08:10
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@voneiden voneiden requested a review from akikoskinen December 29, 2023 08:36
Copy link
Contributor

@nicobav nicobav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise LOKTM!

Building review failed though 🤔

@voneiden
Copy link
Contributor Author

voneiden commented Jan 3, 2024

Yeah @nicobav the kolga review env is broken, it can be removed, there's a PR in progress on the matter @ #465

@voneiden voneiden merged commit 85e09b2 into develop Jan 3, 2024
5 of 6 checks passed
@voneiden voneiden deleted the hp-2087-update-ssn-regex branch January 3, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants