HP-2082 | Update Graphene, Django and Python #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charn
force-pushed
the
HP-2082-python-graphene-django-update
branch
3 times, most recently
from
b093431 to
b60a6f0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
+ Coverage 90.92% 95.50% +4.57%
==========================================
Files 55 207 +152
Lines 2821 8186 +5365
Branches 334 982 +648
==========================================
+ Hits 2565 7818 +5253
- Misses 200 282 +82
- Partials 56 86 +30 ☔ View full report in Codecov by Sentry. |
Refs: HP-2082
Current production environments use a more recent version of postgresql and postgis. This update will also be required for raising the version of Django. Refs: HP-2082
Use python docker image. Copy useful tools from the helsinkitest image. Refs: HP-2082
charn
force-pushed
the
HP-2082-python-graphene-django-update
branch
2 times, most recently
from
39c37c1 to
5f13609
Compare
AntiAki-M
approved these changes
Jan 31, 2024
Bumped most of requirements in the project. Notable mentions: - Use latest Django LTS 4.2 - graphene and graphene-django bumped to latest - Bump psycopg 3 as recommended in Django 4.2 documentation - Use a maintained version django-enumfields2 - Lift graphene version limit for graphene-validator Also: - Add ipython for better python console Refs: HP-2082
Also fix isort command for bumped isort. Refs: HP-2082
Language is a enum instead of a string. Refs: HP-2082
…e_profile Test was using methods which were apparently deprecated. Refs: HP-2082
Django DjangoFilterConnectionField changes order_by filter arguments to snake case, so field mapping should have arguments as snake case. Refs: HP-2082, graphql-python/graphene-django@c049ab7
When there's an exception/error happening in the API, the data part in the response is None, instead of the data part containing some keys. Refs: HP-2082
Schema generation is more verbose, update the test content to reflect that. Refs: HP-2082
Updated packages add tiny changes to the generate the schema. Mostly just ordered differently, but also more modern federation related types. Refs: HP-2082
Same information seems to available under a different attribute. Refs: HP-2082
Refs: HP-2082
Data loaders that exist are not fully compatible with new versions of graphene and graphene-django. DjangoConnectionField doesn't seem to handle loaders correctly and instead return errors like: "Cannot return null for non-nullable field EmailNodeConnection.edges." So for now, data loaders will be disabled for this field type. Use graphql-sync-dataloaders to make other types of fields work with data loaders. Some GitHub issues for reference: - graphql-python/graphene-django#1394 - graphql-python/graphene-django#1263 - graphql-python/graphene-django#1425 Refs: HP-2082
charn
force-pushed
the
HP-2082-python-graphene-django-update
branch
from
5f13609 to
077b6de
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped most of requirements in the project. Notable mentions:
Includes a lot fixes due to deprecated features and functionality in the updated packages.
TODO Fix data loaders to work with the new packages.