Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP-1787 | fix: do keycloak changes inside a transaction #470

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

charn
Copy link
Contributor

@charn charn commented Feb 14, 2024

In case Keycloak returns an error we need to be able to revert.

@charn charn requested a review from a team February 14, 2024 14:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2c2c7c7) 95.55% compared to head (c86a2a3) 95.55%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #470   +/-   ##
=======================================
  Coverage   95.55%   95.55%           
=======================================
  Files         207      207           
  Lines        8215     8215           
  Branches      991      991           
=======================================
  Hits         7850     7850           
  Misses        279      279           
  Partials       86       86           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charn charn force-pushed the HP-1787-keycloack-changes-to-transaction branch from c86a2a3 to 94af600 Compare February 14, 2024 15:08
In case Keycloak returns an error we need to be
able to revert.

Refs: HP-1787
@charn charn force-pushed the HP-1787-keycloack-changes-to-transaction branch from 94af600 to 860a140 Compare February 14, 2024 15:12
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@voneiden voneiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an improvement to me. 👍

@charn charn merged commit 84b62e2 into main Feb 15, 2024
6 checks passed
@charn charn deleted the HP-1787-keycloack-changes-to-transaction branch February 15, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants