Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: readiness return version info, sentry get git commit hash #479

Merged
merged 10 commits into from
Mar 28, 2024
Merged

feat: readiness return version info, sentry get git commit hash #479

merged 10 commits into from
Mar 28, 2024

Conversation

terovirtanen
Copy link
Contributor

@terovirtanen terovirtanen commented Mar 27, 2024 •
edited by jira bot
Loading

@terovirtanen
Copy link
Contributor Author

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr479.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen terovirtanen changed the title fix: readiness return version info, sentry get git commit hash feat: readiness return version info, sentry get git commit hash Mar 28, 2024
@terovirtanen
Copy link
Contributor Author

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr479.api.dev.hel.ninja 🚀🚀🚀

charn
charn reviewed Mar 28, 2024
View reviewed changes
open_city_profile/urls.py Outdated Show resolved Hide resolved
@terovirtanen
Copy link
Contributor Author

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr479.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor Author

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr479.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor Author

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr479.api.dev.hel.ninja 🚀🚀🚀

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.52%. Comparing base (f505b24) to head (4b35343).
Report is 8 commits behind head on main.

Files Patch % Lines
open_city_profile/urls.py 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   95.56%   95.52%   -0.04%     
==========================================
  Files         207      208       +1     
  Lines        8222     8264      +42     
  Branches      991      997       +6     
==========================================
+ Hits         7857     7894      +37     
- Misses        279      285       +6     
+ Partials       86       85       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 65%)
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@terovirtanen
Copy link
Contributor Author

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr479.api.dev.hel.ninja 🚀🚀🚀

@terovirtanen terovirtanen requested a review from charn March 28, 2024 10:20
charn
charn approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@charn charn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 :shipit:

@terovirtanen terovirtanen merged commit fce8d90 into main Mar 28, 2024
22 of 23 checks passed
@terovirtanen terovirtanen deleted the version_info_OH-56 branch March 28, 2024 11:38
@github-actions github-actions bot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charn charn charn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@terovirtanen @codecov-commenter @charn