Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP-2293 | Privacy policy and terms of use urls for service #481

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

nicobav
Copy link
Contributor

@nicobav nicobav commented Apr 3, 2024

Adds translatable privacy policy and terms of use urls to Service.

Refs HP-2136

@nicobav nicobav requested a review from a team April 3, 2024 13:38
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (f505b24) to head (db9c567).
Report is 9 commits behind head on main.

❗ Current head db9c567 differs from pull request most recent head 6476ca1. Consider uploading reports for the commit 6476ca1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   95.56%   95.53%   -0.03%     
==========================================
  Files         207      209       +2     
  Lines        8222     8283      +61     
  Branches      991      998       +7     
==========================================
+ Hits         7857     7913      +56     
- Misses        279      285       +6     
+ Partials       86       85       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicobav nicobav force-pushed the HP-2293/data-protection-and-usage-terms branch from db9c567 to 6476ca1 Compare April 3, 2024 13:51
@nicobav nicobav force-pushed the HP-2293/data-protection-and-usage-terms branch from 6476ca1 to 4a4184a Compare April 3, 2024 13:55
Copy link

sonarqubecloud bot commented Apr 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 65%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@terovirtanen
Copy link
Contributor

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr481.api.dev.hel.ninja 🚀🚀🚀

Copy link
Contributor

@voneiden voneiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes yes

@nicobav nicobav merged commit 04929c9 into main Apr 8, 2024
22 of 23 checks passed
@nicobav nicobav deleted the HP-2293/data-protection-and-usage-terms branch April 8, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants