Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HP-2350 | feat: disable graphql introspection queries #482

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

charn
Copy link
Contributor

@charn charn commented Apr 10, 2024

GraphQL queries starting with __ e.g. __schema will be disabled by default.

@charn charn requested a review from a team April 10, 2024 06:47
@charn charn force-pushed the HP-2350-introspection-queries branch from 7bafb07 to 5d5e86b Compare April 10, 2024 06:50
GraphQL queries starting with `__` e.g. `__schema` will
be disabled by default.

Refs: HP-2350
@charn charn force-pushed the HP-2350-introspection-queries branch from 5d5e86b to 1cbd671 Compare April 10, 2024 06:52
Copy link
Contributor

@voneiden voneiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bon

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 95.51%. Comparing base (f505b24) to head (1cbd671).
Report is 12 commits behind head on main.

Files Patch % Lines
open_city_profile/views.py 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
- Coverage   95.56%   95.51%   -0.05%     
==========================================
  Files         207      209       +2     
  Lines        8222     8321      +99     
  Branches      991     1004      +13     
==========================================
+ Hits         7857     7948      +91     
- Misses        279      287       +8     
  Partials       86       86              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 65%)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@terovirtanen
Copy link
Contributor

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr482.api.dev.hel.ninja 🚀🚀🚀

@charn charn merged commit 4f65ed7 into main Apr 10, 2024
22 of 23 checks passed
@charn charn deleted the HP-2350-introspection-queries branch April 10, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants