HP-2348: Clean up todos #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add ticket numbers - remove some of the todos OM-297 seemed to be finished already, but couldn't find anything in git log indicating that it's actually finished. No idea what the vague "error handling" was referring to, so deleted the comment.
danipran
changed the title
|
|
HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr484.api.dev.hel.ninja 🚀🚀🚀 |
nicobav
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ticket numbers in TODOs and remove some of the TODOs.
Also implemented one of the TODO comments since it was so trivial; from what I gather, it meant raising aPermissionDeniederror.EDIT: The tests state that there should be no errors, so I'm going with the tests and assume there shouldn't be any errors raised in
resolve_sensitivedata.