HP-2372: Replace APINotImplementedError with ProfileAlreadyExistsForUserError #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charn
reviewed
Apr 12, 2024
charn
reviewed
Apr 12, 2024
|
HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr485.api.dev.hel.ninja 🚀🚀🚀 |
danipran
force-pushed
the
HP-2372/replace-api-not-implemented-error
branch
from
d27da82 to
e2b5e31
Compare
charn
reviewed
Apr 12, 2024
Replaces APINotImplementedError in ClaimProfileMutation. Refs: HP-2372
Not in use anymore.
danipran
force-pushed
the
HP-2372/replace-api-not-implemented-error
branch
from
e2b5e31 to
dcd0ce4
Compare
|
|
HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr485.api.dev.hel.ninja 🚀🚀🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TODO for OM-385/HP-2368 is obsolete, so replace the
APINotImplementedErrorwith something more descriptive (since it won't be implemented), i.e.ProfileAlreadyExistsForUserError.APINotImplementedErroris not used anymore after this, so remove it as well.Also remove another obsolete TODO (HP-2370).