HP-2344 | Shorten profile name fields to 150 characters #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: HP-2344
|
HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr488.api.dev.hel.ninja 🚀🚀🚀 |
First and last name need to be limited to 150 characters on the Profile model. Updates to name information are also sent to keycloak, which will put the name information into the API tokens that it produces. User model has 150 character name fields. Upon receiving an API token this backend will try to update the user object with the information in the token. If the name is over 150 characters an error will be produced and the user will be unable to use the API. Users with this error will also be unable to resolve the issue by themselves. Refs: HP-2344
charn
force-pushed
the
HP-2344-profile-name-field-length
branch
from
aeea8e4 to
74298f3
Compare
|
|
HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr488.api.dev.hel.ninja 🚀🚀🚀 |
tuomas777
approved these changes
Apr 17, 2024
Comment on lines
+9
to
+13
| def truncate_name_fields(apps, schema_editor): | ||
| Profile = apps.get_model("profiles", "Profile") | ||
| Profile.objects.update( | ||
| first_name=Substr("first_name", 1, 150), last_name=Substr("last_name", 1, 150) | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First and last name need to be limited to 150 characters on the
Profilemodel. Updates to name fields are also sent to keycloak, which will put the name information into the API tokens that it produces.Usermodel has 150 character name fields. Upon receiving an API token this backend will try to update the user object with the information in the token. If a name field is over 150 characters an error will be produced and the user will be unable to use the API. Users with this error will also be unable to resolve the issue by themselves.