Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSP protection via django-csp #490

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Add CSP protection via django-csp #490

merged 2 commits into from
Apr 24, 2024

Conversation

voneiden
Copy link
Contributor

@voneiden voneiden commented Apr 19, 2024 •
edited
Loading

voneiden added 2 commits April 19, 2024 12:22
@voneiden
chore: add django-csp
21acdfb 
Refs: HP-2390
@voneiden
chore: include swagger-ui in staticfiles
3820135 
CSP best practice is to not include scripts and styles from untrusted
domains.
@voneiden voneiden requested a review from a team April 19, 2024 09:26
@voneiden voneiden changed the title Csp Add CSP protection via django-csp Apr 19, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 19, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr490.api.dev.hel.ninja 🚀🚀🚀

tuomas777
tuomas777 approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@tuomas777 tuomas777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@voneiden voneiden merged commit 482ac33 into main Apr 24, 2024
23 checks passed
@voneiden voneiden deleted the csp branch April 24, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuomas777 tuomas777 tuomas777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@voneiden @terovirtanen @tuomas777