Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable query suggestions #496

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

charn
Copy link
Contributor

@charn charn commented Apr 29, 2024

When graphql introspection is disabled, query suggestion feature should also be disabled. Query suggestions are disabled by monkey patching graphql-core did_you_mean module.

Refs: HP-2351

@charn charn requested a review from a team April 29, 2024 19:37
@terovirtanen
Copy link
Contributor

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr496.api.dev.hel.ninja 🚀🚀🚀

When graphql introspection is disabled,	query suggestion
feature	should also be disabled. Query suggestions are
disabled by monkey patching graphql-core did_you_mean module.

Refs: HP-2351
@charn charn force-pushed the HP-2351-disable-query-suggestion branch from 6057153 to 1c1f5a3 Compare April 30, 2024 07:56
Copy link

@terovirtanen
Copy link
Contributor

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr496.api.dev.hel.ninja 🚀🚀🚀

@charn charn merged commit 8556826 into main May 2, 2024
23 checks passed
@charn charn deleted the HP-2351-disable-query-suggestion branch May 2, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants