Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont check fields in middleware when missing service #504

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

nicobav
Copy link
Contributor

@nicobav nicobav commented Jun 4, 2024

Don't try to check fields if service exists

Refs HP-2319

@nicobav nicobav requested a review from a team June 4, 2024 13:39
Don't try to check fields if service does not exists

Refs HP-2319
@nicobav nicobav force-pushed the HP-2319/fix-flag-usage branch from 9fb457f to ba414e4 Compare June 4, 2024 13:41
Copy link

sonarqubecloud bot commented Jun 4, 2024

@terovirtanen
Copy link
Contributor

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr504.api.dev.hel.ninja 🚀🚀🚀

Copy link
Contributor

@charn charn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, worked. LGTM! 👍 :shipit:

@charn charn merged commit 8aeaeac into main Jun 4, 2024
26 checks passed
@charn charn deleted the HP-2319/fix-flag-usage branch June 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants