Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HP-2490: Add login_methods field in ProfileNode #507

Merged
merged 10 commits into from
Jul 24, 2024
Merged

HP-2490: Add login_methods field in ProfileNode #507

merged 10 commits into from
Jul 24, 2024

Conversation

danipran
Copy link
Contributor

No description provided.

@danipran danipran force-pushed the HP-2490/add-credential-types branch 3 times, most recently from 54d2ada to 4744869 Compare July 23, 2024 10:05
@danipran danipran requested a review from charn July 23, 2024 10:21
@danipran danipran marked this pull request as ready for review July 23, 2024 10:21
@danipran danipran force-pushed the HP-2490/add-credential-types branch from 4744869 to 333dcba Compare July 23, 2024 12:10
charn
charn reviewed Jul 23, 2024
View reviewed changes
profiles/schema.py Outdated Show resolved Hide resolved
@danipran danipran requested a review from charn July 23, 2024 12:24
danipran
danipran commented Jul 23, 2024
View reviewed changes
profiles/schema.py Outdated Show resolved Hide resolved
@danipran danipran marked this pull request as draft July 23, 2024 12:52
@danipran
fix: force amr claim to list
78ce23a 
Apparently, this can be either a string or a list.

Refs: HP-2490
@danipran danipran force-pushed the HP-2490/add-credential-types branch from cd57c80 to 78ce23a Compare July 23, 2024 12:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.90110% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.65%. Comparing base (f505b24) to head (0a1331b).
Report is 44 commits behind head on main.

Files Patch % Lines
profiles/tests/test_gql_my_profile_query.py 95.45% 1 Missing ⚠️
utils/keycloak.py 97.22% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
+ Coverage   95.56%   95.65%   +0.09%     
==========================================
  Files         207      216       +9     
  Lines        8222     8815     +593     
  Branches      991     1057      +66     
==========================================
+ Hits         7857     8432     +575     
- Misses        279      290      +11     
- Partials       86       93       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terovirtanen
Copy link
Contributor

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr507.api.dev.hel.ninja 🚀🚀🚀

@danipran danipran marked this pull request as ready for review July 24, 2024 07:39
charn
charn reviewed Jul 24, 2024
View reviewed changes
profiles/enums.py Outdated
PASSWORD = "password"
OTP = "otp"
SUOMI_FI = "suomi_fi"
HELSINKIAD = "helsinkiad"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove HELSINKIAD since at least by definition Helsinki AD users should not get a Helsinki profile.

@danipran danipran force-pushed the HP-2490/add-credential-types branch from aa0b7e9 to c6b0c4a Compare July 24, 2024 11:08
@terovirtanen
Copy link
Contributor

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr507.api.dev.hel.ninja 🚀🚀🚀

charn
charn reviewed Jul 24, 2024
View reviewed changes
profiles/schema.py Outdated Show resolved Hide resolved
@danipran danipran force-pushed the HP-2490/add-credential-types branch from c6b0c4a to 1db34aa Compare July 24, 2024 11:24
@danipran danipran requested a review from charn July 24, 2024 12:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
99.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

HELSINKI-PROFILE-API branch is deployed to platta: https://helsinki-profile-pr507.api.dev.hel.ninja 🚀🚀🚀

charn
charn approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@charn charn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 :shipit:

@danipran danipran merged commit 9016a41 into main Jul 24, 2024
24 of 26 checks passed
@danipran danipran deleted the HP-2490/add-credential-types branch July 24, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charn charn charn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danipran @codecov-commenter @terovirtanen @charn