Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix card button styling #1594

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix card button styling #1594

wants to merge 2 commits into from

Conversation

joonatank
Copy link
Contributor

@joonatank joonatank commented Feb 25, 2025 •
edited
Loading

🛠️ Changelog

  • fix: set expand buttons (multiple) inside a card
  • fix: tab z-index over mobile navigation
  • fix: Finnish translation of a button

🧪 Test plan

  • Manual tests

🚧 Dependencies

  • None

🎫 Tickets

  • None

@github-actions github-actions bot added the fix Fixes a bug label Feb 25, 2025
@joonatank
fix: finnish translation of a button
973d679
@joonatank
fix: minor style issues
d30ea1d 
- on mobile set width to card buttons so they expand
- set z-index to navigation so tabs are not over it
@joonatank joonatank force-pushed the fix-card-button-styling branch from 069d4aa to d30ea1d Compare February 25, 2025 11:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vincit-matu
vincit-matu approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@vincit-matu vincit-matu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincit-matu vincit-matu vincit-matu approved these changes

Assignees
No one assigned
Labels
fix Fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joonatank @vincit-matu