Skip to content

Commit

Permalink
fix: chrome v130 crashes on startup (#3450)
Browse files Browse the repository at this point in the history 
* fix: use chromium in ci

* fix: handler test broken
  • Loading branch information
@sirtawast
sirtawast authored Oct 24, 2024
1 parent 72820b4 commit cad4466
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 14 deletions.
6 changes: 3 additions & 3 deletions frontend/benefit/applicant/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
"test": "jest --passWithNoTests",
"test:staged": "yarn test --watchAll=false --findRelatedTests",
"test:coverage": "yarn test --verbose --coverage",
"browser-test": "testcafe 'chrome --allow-insecure-localhost --disable-search-engine-choice-screen --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/pages/*.testcafe.ts --sf",
"browser-test:headless": "testcafe 'chrome:headless --disable-search-engine-choice-screen --allow-insecure-localhost --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/pages/*.testcafe.ts --sf",
"browser-test:ci": "testcafe 'chrome:headless --disable-search-engine-choice-screen --disable-gpu --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/pages/*.testcafe.ts --sf"
"browser-test": "testcafe 'chromium --allow-insecure-localhost --disable-search-engine-choice-screen --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/pages/*.testcafe.ts --sf",
"browser-test:headless": "testcafe 'chromium:headless --disable-search-engine-choice-screen --allow-insecure-localhost --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/pages/*.testcafe.ts --sf",
"browser-test:ci": "testcafe 'chromium:headless --disable-search-engine-choice-screen --disable-gpu --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/pages/*.testcafe.ts --sf"
},
"dependencies": {
"@frontend/benefit-shared": "*",
Expand Down
2 changes: 1 addition & 1 deletion frontend/benefit/handler/browser-tests/pages/7-handle-alteration.testcafe.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ test('Handler handles the alteration from the last test properly', async (t: Tes
)
.ok();
await t
.expect(item.find('dl dd').withText(getCurrencyString(180)).exists)
.expect(item.find('dl dd').withText(getCurrencyString(180, 0)).exists)
.ok();
});

Expand Down
4 changes: 2 additions & 2 deletions frontend/benefit/handler/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"test": "jest --passWithNoTests",
"test:staged": "yarn test --watchAll=false --findRelatedTests",
"test:coverage": "yarn test --verbose --coverage",
"browser-test": "testcafe 'chrome --disable-search-engine-choice-screen --allow-insecure-localhost --disable-web-security --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' --sf browser-tests/pages/",
"browser-test:ci": "testcafe 'chrome:headless --disable-search-engine-choice-screen --allow-insecure-localhost --disable-web-security --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/pages/ --sf"
"browser-test": "testcafe 'chromium --disable-search-engine-choice-screen --allow-insecure-localhost --disable-web-security --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' --sf browser-tests/pages/",
"browser-test:ci": "testcafe 'chromium:headless --disable-search-engine-choice-screen --allow-insecure-localhost --disable-web-security --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/pages/ --sf"
},
"dependencies": {
"@frontend/benefit-shared": "*",
Expand Down
4 changes: 2 additions & 2 deletions frontend/kesaseteli/employer/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"test:debug-dom": "cross-env DEBUG_PRINT_LIMIT=1000000 yarn test",
"test:staged": "yarn test --watchAll=false --findRelatedTests",
"test:coverage": "yarn test --verbose --coverage",
"browser-test": "testcafe 'chrome --disable-search-engine-choice-screen --allow-insecure-localhost --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/",
"browser-test:ci": "testcafe 'chrome:headless --disable-search-engine-choice-screen --disable-gpu --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/"
"browser-test": "testcafe 'chromium --disable-search-engine-choice-screen --allow-insecure-localhost --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/",
"browser-test:ci": "testcafe 'chromium:headless --disable-search-engine-choice-screen --disable-gpu --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/"
},
"dependencies": {
"@frontend/kesaseteli-shared": "*",
Expand Down
4 changes: 2 additions & 2 deletions frontend/kesaseteli/handler/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"test:debug-dom": "cross-env DEBUG_PRINT_LIMIT=1000000 yarn test",
"test:staged": "yarn test --watchAll=false --findRelatedTests",
"test:coverage": "yarn test:debug-dom --verbose --coverage",
"browser-test": "testcafe 'chrome --disable-search-engine-choice-screen --allow-insecure-localhost --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/",
"browser-test:ci": "testcafe 'chrome:headless --disable-search-engine-choice-screen --disable-gpu --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/"
"browser-test": "testcafe 'chromium --disable-search-engine-choice-screen --allow-insecure-localhost --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/",
"browser-test:ci": "testcafe 'chromium:headless --disable-search-engine-choice-screen --disable-gpu --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/"
},
"dependencies": {
"@frontend/kesaseteli-shared": "*",
Expand Down
4 changes: 2 additions & 2 deletions frontend/kesaseteli/youth/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"test:debug-dom": "cross-env DEBUG_PRINT_LIMIT=1000000 yarn test",
"test:staged": "yarn test --watchAll=false --findRelatedTests",
"test:coverage": "yarn test:debug-dom --verbose --coverage",
"browser-test": "testcafe 'chrome --disable-search-engine-choice-screen --allow-insecure-localhost --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/",
"browser-test:ci": "testcafe 'chrome:headless --disable-search-engine-choice-screen --disable-gpu --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/",
"browser-test": "testcafe 'chromium --disable-search-engine-choice-screen --allow-insecure-localhost --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/",
"browser-test:ci": "testcafe 'chromium:headless --disable-search-engine-choice-screen --disable-gpu --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/",
"browser-test:wsl2win": "testcafe 'path:`/mnt/c/Program Files/Google/Chrome/Application/chrome.exe` --disable-search-engine-choice-screen --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --live --dev --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion frontend/tet/admin/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"test:coverage": "yarn test:debug-dom --verbose --coverage",
"test:debug-nock": "cross-env DEBUG=nock.* yarn test",
"browser-test": "cross-env LOCAL_TEST_RUN=1 testcafe 'chrome --disable-search-engine-choice-screen --allow-insecure-localhost --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/ --experimental-proxyless",
"browser-test:ci": "testcafe 'chrome:headless --disable-search-engine-choice-screen --disable-gpu --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/",
"browser-test:ci": "testcafe 'chromium:headless --disable-search-engine-choice-screen --disable-gpu --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/",
"lint": "eslint --ext js,ts,tsx src"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion frontend/tet/youth/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"test:staged": "yarn test --watchAll=false --findRelatedTests",
"test:coverage": "yarn test:debug-dom --verbose --coverage",
"browser-test": "cross-env LOCAL_TEST_RUN=1 testcafe 'chrome --disable-search-engine-choice-screen --allow-insecure-localhost --ignore-certificate-errors --ignore-urlfetcher-cert-requests --window-size=\"1249,720\"' browser-tests/ --experimental-proxyless",
"browser-test:ci": "testcafe 'chrome:headless --disable-gpu --disable-search-engine-choice-screen --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/ --experimental-proxyless",
"browser-test:ci": "testcafe 'chromium:headless --disable-gpu --disable-search-engine-choice-screen --window-size=\"1249,720\" --ignore-certificate-errors-spki-list=\"8sg/cl7YabrOFqSqH+Bu0e+P27Av33gWgi8Lq28DW1I=,gJt+wt/T3afCRkxtMMSjXcl/99sgzWc2kk1c1PC9tG0=,zrQI2/1q8i2SRPmMZ1sMntIkG+lMW0legPFokDo3nrY=\"' --screenshots path=report --video report --reporter spec,html:report/index.html browser-tests/ --experimental-proxyless",
"lint": "eslint --ext js,ts,tsx src browser-tests"
},
"dependencies": {
Expand Down

0 comments on commit cad4466

Please sign in to comment.