fix: yup fails to validate 0 as min value

City-of-Helsinki · Dec 14, 2023 · e4127b8 · e4127b8
1 parent 43810e0
commit e4127b8
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/...benefit/applicant/src/components/applications/forms/application/step2/utils/validation.ts b/...benefit/applicant/src/components/applications/forms/application/step2/utils/validation.ts
@@ -113,7 +113,9 @@ export const getValidationSchema = (
           max: param.max,
           key: VALIDATION_MESSAGE_KEYS.NUMBER_MAX,
         }))
-        .transform((_value, originalValue) => getNumberValue(originalValue))
+        .transform((_value, originalValue) =>
+          originalValue ? getNumberValue(originalValue) : null
+        )
         .typeError(t(VALIDATION_MESSAGE_KEYS.NUMBER_INVALID))
         .required(t(VALIDATION_MESSAGE_KEYS.REQUIRED)),
       [EMPLOYEE_KEYS.MONTHLY_PAY]: Yup.number()
@@ -125,7 +127,9 @@ export const getValidationSchema = (
           max: param.max,
           key: VALIDATION_MESSAGE_KEYS.NUMBER_MAX,
         }))
-        .transform((_value, originalValue) => getNumberValue(originalValue))
+        .transform((_value, originalValue) =>
+          originalValue ? getNumberValue(originalValue) : null
+        )
         .typeError(t(VALIDATION_MESSAGE_KEYS.NUMBER_INVALID))
         .required(t(VALIDATION_MESSAGE_KEYS.REQUIRED)),
       [EMPLOYEE_KEYS.OTHER_EXPENSES]: Yup.number()
@@ -137,7 +141,9 @@ export const getValidationSchema = (
           max: param.max,
           key: VALIDATION_MESSAGE_KEYS.NUMBER_MAX,
         }))
-        .transform((_value, originalValue) => getNumberValue(originalValue))
+        .transform((_value, originalValue) =>
+          originalValue ? getNumberValue(originalValue) : null
+        )
         .typeError(t(VALIDATION_MESSAGE_KEYS.NUMBER_INVALID))
         .required(t(VALIDATION_MESSAGE_KEYS.REQUIRED)),
       [EMPLOYEE_KEYS.COLLECTIVE_BARGAINING_AGREEMENT]: Yup.string().required(