Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL-861 | Use markdown format to display service terms #2172

Merged
merged 5 commits into from
Oct 27, 2023
Merged

HL-861 | Use markdown format to display service terms #2172

merged 5 commits into from
Oct 27, 2023

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Aug 16, 2023 •
edited
Loading

Description ✨

Affects:

  • When applicant logs into service
  • When applicant is submitting application

Save terms as MD, display them in MD. Benefits are:

  • natively responsive (it's HTML)
  • accessibility improves as it's just regular text
  • can be updated without creating, then uploading the right PDF

Admin / single terms view with different preview edit modes

screencapture-localhost-8000-admin-terms-terms-c9cd762d-8256-4939-b916-d6762e66bf62-change-2023-08-16-14_38_47

Frontend

image

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023 •
edited
Loading

Codecov Report

Merging #2172 (a3008f3) into main (a6d126f) will increase coverage by 2.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2172      +/-   ##
==========================================
+ Coverage   30.03%   32.75%   +2.72%     
==========================================
  Files         823      701     -122     
  Lines       16199    13507    -2692     
  Branches     3203     2637     -566     
==========================================
- Hits         4865     4424     -441     
+ Misses      10808     8640    -2168     
+ Partials      526      443      -83

see 122 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2172.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://handler-pr2172.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://youth-pr2172.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EMPLOYER branch is deployed to platta: https://kesaseteli-pr2172.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-admn is deployed to: https://te-admn-2172.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-yout is deployed to: https://te-yout-2172.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-appl is deployed to: https://helsinkibenefit-bf-appl-2172.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://handler-pr2172.dev.hel.ninja 😆🎉🎉🎉

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-bknd is deployed to: https://helsinkibenefit-bf-bknd-2172.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

Helsinkibenefit-bf-hdlr is deployed to: https://helsinkibenefit-bf-hdlr-2172.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2172.api.dev.hel.ninja/healthz 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-youth is deployed to: https://ks-youth-2172.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2172.dev.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-hdlr is deployed to: https://ks-hdlr-2172.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-empl is deployed to: https://ks-empl-2172.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

te-bknd is deployed to: https://te-bknd-2172.test.kuva.hel.ninja 🚀🚀🚀

@github-actions
Copy link
Contributor

ks-bknd is deployed to: https://ks-bknd-2172.test.kuva.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://kesaseteli-pr2172.dev.hel.ninja 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://te-yout-2172.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://te-admn-2172.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-handler-2172.test.kuva.hel.ninja! 😆🎉🎉🎉

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023 •
edited
Loading

TestCafe result is failure for https://helsinkibenefit-bf-appl-2172.! 😿💢💥💥

Check the report on:

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-empl-2172.test.kuva.hel.ninja! 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://youth-pr2172.dev.hel.ninja 😆🎉🎉🎉

@github-actions
Copy link
Contributor

TestCafe result is success for https://ks-youth-2172.test.kuva.hel.ninja! 😆🎉🎉🎉

@sirtawast sirtawast changed the title HL-861 | Use MD format to display service terms HL-861 | Use markdown format to display service terms Aug 16, 2023
@sirtawast sirtawast requested review from rikuke and mjturt August 18, 2023 07:21
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2172.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2172.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2172.dev.hel.ninja 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh-kesaseteli-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh-kesaseteli-handler] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

84.7% 84.7% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 140 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh-kesaseteli-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 62 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh-kesaseteli-employer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 36 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 160 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 34 Code Smells

71.0% 71.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh-tet-admin] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 100 Code Smells

71.2% 71.2% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh-tet-youth] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 63 Code Smells

29.0% 29.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh-tet-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 43 Code Smells

42.8% 42.8% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh-kesaseteli-youth] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 16 Code Smells

91.8% 91.8% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

71.4% 71.4% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2172.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr2172.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2172.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2172.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2172.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2172.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2172.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2172.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-youth-ui-pr2172.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-admin-ui-pr2172.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2172.dev.hel.ninja 😆🎉🎉🎉

@sirtawast sirtawast merged commit 5f7d53a into main Oct 27, 2023
153 of 157 checks passed
@sirtawast sirtawast deleted the hl-861 branch October 27, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjturt mjturt mjturt left review comments

@rikuke rikuke rikuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sirtawast @codecov-commenter @terovirtanen @mjturt @rikuke