Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HL-926: Handle case when there's no company address #2234

Merged
merged 1 commit into from
Aug 30, 2023
Merged

HL-926: Handle case when there's no company address #2234

merged 1 commit into from
Aug 30, 2023

Conversation

mjturt
Copy link
Contributor

@mjturt mjturt commented Aug 28, 2023

Description ✨

YTJ (service bus) integration failed when there was no company address.

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@sirtawast
Copy link
Collaborator

I have no idea what is going on so maybe @rikuke check this

@mjturt mjturt requested review from sirtawast and rikuke August 29, 2023 18:04
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2234.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2234.dev.hel.ninja 😆🎉🎉🎉

@mjturt mjturt closed this Aug 29, 2023
@mjturt mjturt reopened this Aug 29, 2023
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2234.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2234.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh-kesaseteli-shared] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh-kesaseteli-handler] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

84.7% 84.7% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh-kesaseteli-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 1 Bug
Vulnerability A 3 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 62 Code Smells

94.5% 94.5% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh-kesaseteli-employer] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.4% 82.4% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://kesaseteli-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh-tet-admin] SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 23 Code Smells

64.5% 64.5% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 34 Code Smells

71.0% 71.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh-tet-shared] SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 3 Code Smells

42.8% 42.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh-tet-youth] SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 9 Code Smells

27.2% 27.2% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://tet-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

[yjdh-kesaseteli-youth] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

91.8% 91.8% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2234.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2234.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2234.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-youth-ui-pr2234.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tet-admin-ui-pr2234.dev.hel.ninja 😆🎉🎉🎉

@mjturt
fix: allow companies without address
fbaf540 
Fix YTJ (Service Bus) integration to allow companies to be saved without address.
@mjturt mjturt merged commit dc78d34 into main Aug 30, 2023
16 checks passed
@mjturt mjturt deleted the hl-926 branch August 30, 2023 19:14
@github-actions github-actions bot mentioned this pull request Aug 30, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Merged
@github-actions github-actions bot mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirtawast sirtawast Awaiting requested review from sirtawast

@rikuke rikuke Awaiting requested review from rikuke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjturt @terovirtanen @sirtawast