HL-930: Release Please docs and git hook & CI modifications #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjturt
force-pushed
the
hl-930
branch
2 times, most recently
from
76e4fe0 to
034b182
Compare
mjturt
requested review from
terovirtanen,
sirtawast,
rikuke and
karisal-anders
mjturt
commented
Sep 1, 2023
| * Pull request title should include Jira handle (for Jira integration to work) | ||
| * Release Please figures out how much to increase the version number based on commit messages. Look [SemVer](https://semver.org/) and [Release Please docs](https://github.com/googleapis/release-please#how-should-i-write-my-commits). | ||
|
|
||
| ### Example workflow |
There was a problem hiding this comment.
What do you think, is this kind of workflow something that could work for us?
rikuke
approved these changes
Sep 5, 2023
terovirtanen
requested changes
Sep 6, 2023
| branches: [main] | ||
| pull_request: | ||
| paths: | ||
| - '.github/workflows/conventional-commits.yml' |
There was a problem hiding this comment.
tarkoitus on varmaan ajaa tämä workflow aina kun pr:aan lisätään commit? Tämä taitaa nyt ajaa vain jos tulee muutos tähän filuun?
There was a problem hiding this comment.
Meidän muissa workfloweissa on tuota viljelty, mutta nyt kun manuskaa tarkemmin katsoo niin eipä siinä kovin järkeä näytä olevan.
Run husky & lint-staged hooks with pre-commit. Add commitlint pre-commit hook.
terovirtanen
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✨