Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hl 1069 ahjo cancel #2589

Merged
merged 3 commits into from
Dec 20, 2023
Merged

Hl 1069 ahjo cancel #2589

merged 3 commits into from
Dec 20, 2023

Conversation

rikuke
Copy link
Collaborator

@rikuke rikuke commented Dec 7, 2023

Description ✨

Adjusts the callback view so that different kinds of callbacks can be received based on the AhjoRequestType enum.
Add a callback address for a DELETE request to Ahjo REST api.

Refactor the function do_ahjo_request_with_json_payload into send_request_to_ahjo that can do different types of requests.

Issues 🐛

Testing ⚗️

pytest applications/tests/test_ahjo_integration.py
pytest applications/tests/test_ahjo_requests.py

Screenshots 📸

Additional notes 🗒️

ahjo_integration_views.py has a function, _handle_delete_callback() which currently does nothing, as placeholder because it's not certain yet, what we should do to the application after it is deleted in Ahjo.

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2589.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2589.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2589.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke force-pushed the HL-1069-ahjo-cancel branch from 0844803 to 77a66fc Compare December 8, 2023 17:46
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2589.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2589.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2589.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke force-pushed the HL-1069-ahjo-cancel branch from 77a66fc to 4fad0a5 Compare December 9, 2023 04:57
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2589.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2589.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2589.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke force-pushed the HL-1069-ahjo-cancel branch from 4fad0a5 to cb679fd Compare December 9, 2023 08:37
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2589.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2589.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2589.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 😆🎉🎉🎉

Copy link

sonarcloud bot commented Dec 11, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Dec 11, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Dec 11, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Dec 11, 2023

[yjdh] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

84.5% 84.5% Coverage
0.0% 0.0% Duplication

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2589.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2589.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2589.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke requested a review from mjturt December 11, 2023 11:43
@rikuke rikuke marked this pull request as ready for review December 11, 2023 11:43
elif request_type == AhjoRequestType.DELETE_APPLICATION:
self._handle_delete_callback()
ahjo_status = AhjoStatusEnum.DELETE_REQUEST_RECEIVED
info = f"""Application was marked for cancellation in Ahjo with request id: {ahjo_request_id}"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why triple "'s?

@rikuke rikuke merged commit a9f66d7 into main Dec 20, 2023
65 checks passed
@rikuke rikuke deleted the HL-1069-ahjo-cancel branch December 20, 2023 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants