-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hl 1069 ahjo cancel #2589
Hl 1069 ahjo cancel #2589
Conversation
API branch is deployed to platta: https://helsinkilisa-pr2589.api.dev.hel.ninja/healthz 🚀🚀🚀 |
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2589.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr2589.dev.hel.ninja 😆🎉🎉🎉 |
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 😆🎉🎉🎉 |
0844803
to
77a66fc
Compare
API branch is deployed to platta: https://helsinkilisa-pr2589.api.dev.hel.ninja/healthz 🚀🚀🚀 |
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2589.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr2589.dev.hel.ninja 😆🎉🎉🎉 |
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 😆🎉🎉🎉 |
77a66fc
to
4fad0a5
Compare
API branch is deployed to platta: https://helsinkilisa-pr2589.api.dev.hel.ninja/healthz 🚀🚀🚀 |
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2589.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr2589.dev.hel.ninja 😆🎉🎉🎉 |
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 😆🎉🎉🎉 |
4fad0a5
to
cb679fd
Compare
API branch is deployed to platta: https://helsinkilisa-pr2589.api.dev.hel.ninja/healthz 🚀🚀🚀 |
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2589.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr2589.dev.hel.ninja 😆🎉🎉🎉 |
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 😆🎉🎉🎉 |
[yjdh] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[yjdh] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[yjdh] Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
[yjdh] Kudos, SonarCloud Quality Gate passed! |
API branch is deployed to platta: https://helsinkilisa-pr2589.api.dev.hel.ninja/healthz 🚀🚀🚀 |
APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2589.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-pr2589.dev.hel.ninja 😆🎉🎉🎉 |
HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://helsinkilisa-ui-handler-pr2589.dev.hel.ninja 😆🎉🎉🎉 |
elif request_type == AhjoRequestType.DELETE_APPLICATION: | ||
self._handle_delete_callback() | ||
ahjo_status = AhjoStatusEnum.DELETE_REQUEST_RECEIVED | ||
info = f"""Application was marked for cancellation in Ahjo with request id: {ahjo_request_id}""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why triple "
's?
Description ✨
Adjusts the callback view so that different kinds of callbacks can be received based on the AhjoRequestType enum.
Add a callback address for a DELETE request to Ahjo REST api.
Refactor the function
do_ahjo_request_with_json_payload
intosend_request_to_ahjo
that can do different types of requests.Issues 🐛
Testing ⚗️
Screenshots 📸
Additional notes 🗒️
ahjo_integration_views.py
has a function,_handle_delete_callback()
which currently does nothing, as placeholder because it's not certain yet, what we should do to the application after it is deleted in Ahjo.