Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify batches to better support TALPA and handler's work (HL-1053) #2615

Merged
merged 3 commits into from
Jan 4, 2024
Merged

fix: modify batches to better support TALPA and handler's work (HL-1053) #2615

merged 3 commits into from
Jan 4, 2024

Conversation

sirtawast
Copy link
Collaborator

@sirtawast sirtawast commented Dec 18, 2023 •
edited
Loading

Description ✨

  • Separate batches that are pending:
    • Those that wait for AHJO decisions awaiting_ahjo_decision (tab 2 - inspection phase)
    • Those that wait for Talpa robot visit accepted and confirmed by robot with sent_to_talpa (tab3 - completion phase)
  • Allow batch status to be set to completed (this happens when "Archive" button is pressed in web UI)
  • Refactor code by splitting components into new files
  • Change rejected application's batch decision status from rejected to completed
  • Fix animations when changing batch status

@sirtawast sirtawast requested a review from mjturt December 18, 2023 12:19
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2615.api.dev.hel.ninja/healthz 🚀🚀🚀

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sirtawast sirtawast changed the title Hl 1053 fix: modify batches to better support TALPA and handler's work (HL-1053) Dec 18, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

The SonarCloud Quality Gate passed, but some issues were introduced.

13 New issues
0 Security Hotspots
No data about Coverage
1.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'yjdh'

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
86.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr2615.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2615.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr2615.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2615.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr2615.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke self-requested a review January 4, 2024 09:58
@sirtawast sirtawast merged commit 8c58eb0 into main Jan 4, 2024
65 checks passed
@sirtawast sirtawast deleted the hl-1053 branch January 4, 2024 11:43
This was referenced Jan 4, 2024
Merged
Merged
@github-actions github-actions bot mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikuke rikuke rikuke approved these changes

@mjturt mjturt Awaiting requested review from mjturt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirtawast @terovirtanen @rikuke