YJDH-691 | Parametrize youth summer voucher email templates & update for 2024 #2823
Conversation
|
API branch is deployed to platta: https://kesaseteli-pr2823.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2823.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-employer-pr2823.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2823.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-pr2823.dev.hel.ninja 😆🎉🎉🎉 |
|
YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2823.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-youth-pr2823.dev.hel.ninja 😆🎉🎉🎉 |
karisal-anders
force-pushed
the
YJDH-691-update-email-templates
branch
from
6ab9a27 to
e603eed
Compare
|
API branch is deployed to platta: https://kesaseteli-pr2823.api.dev.hel.ninja/healthz 🚀🚀🚀 |
also: - change employer summer vouchers to use previous year's voucher value until 13th of February (i.e. last day before the new year's youth summer voucher application period starts) refs YJDH-691
karisal-anders
force-pushed
the
YJDH-691-update-email-templates
branch
from
e603eed to
b8dfd3f
Compare
|
|
|
|
|
API branch is deployed to platta: https://kesaseteli-pr2823.api.dev.hel.ninja/healthz 🚀🚀🚀 |
|
|
EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2823.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-employer-pr2823.dev.hel.ninja 😆🎉🎉🎉 |
|
HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2823.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-handler-pr2823.dev.hel.ninja 😆🎉🎉🎉 |
|
YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2823.dev.hel.ninja 🚀🚀🚀 |
TestCafe result is success for https://kesaseteli-youth-pr2823.dev.hel.ninja 😆🎉🎉🎉 |
|
@nikomakela @melniiv @jakezu Added examples of newly generated emails (.eml files) + plaintext versions & screencaptures of the HTML emails for ease-of-review. |
karisal-anders
changed the title
karisal-anders
changed the title
| @@ -29,15 +29,12 @@ <h2>{% trans 'Kesäsetelisi, ole hyvä' %}</h2> | |||
| <p> | |||
| <strong>{{first_name}} {{last_name}}</strong><br/> | |||
| <strong>{% trans 'Kesäsetelinumero:' %}</strong> {{summer_voucher_serial_number}}<br/> | |||
| <strong>{% trans 'Kesäsetelin summa:' %}</strong> {% trans '350€' %}<br/> | |||
| <strong>{% trans 'Kesäsetelin summa:' %}</strong> {{voucher_value_with_euro_sign}}<br/> | |||
There was a problem hiding this comment.
It would be much better to give the value as a variable for the translation itself. Then they would be tied together and different locales could represent it differently, for example in different order. Sure this is already in a definition table / list format, so it does not matter that much.
There was a problem hiding this comment.
Hmm, that's done already in this PR, see definition of voucher_value_with_euro_sign.
There was a problem hiding this comment.
I mean the value comes from a property, and the currency sign (€) is localized to be in front or back of the value per language.
Description ✨
feat: parametrize youth summer voucher email templates & update for 2024
also:
until 13th of February (i.e. last day before the new year's youth
summer voucher application period starts)
refs YJDH-691
Issues 🐛
YJDH-691
Testing ⚗️
Finnish youth summer voucher email
Download and rename to
fi.emland you can open this in an email client:HTML:
Plaintext:
Swedish youth summer voucher email
Download and rename to
sv.emland you can open this in an email client:HTML:
Plaintext:
English youth summer voucher email
Download and rename to
en.emland you can open this in an email client:HTML:
Plaintext:
Screenshots 📸
Additional notes 🗒️