chore: update hds-(design-tokens|react)->2.17.1, unwhitelist lodash.pick #2826

karisal-anders · 2024-02-12T14:58:59Z

Description ✨

chore: update hds-(design-tokens|react)->2.17.1, unwhitelist lodash.pick

Issues 🐛

Testing ⚗️

Screenshots 📸

Additional notes 🗒️

karisal-anders · 2024-02-12T15:06:42Z

I don't see any reason not to do this upgrade to HDS v2.17.1, how do you feel Helsinki benefit team? @sirtawast @EmiliaMakelaVincit @rikuke? Please approve this PR if you feel this is ok for you. I don't think this needs to be code reviewed by all parties IMO, simply if any of you give approval I'll just merge this. Thank you!

terovirtanen · 2024-02-12T15:14:27Z

API branch is deployed to platta: https://tet-pr2826.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-02-12T15:15:24Z

API branch is deployed to platta: https://helsinkilisa-pr2826.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-02-12T15:18:23Z

API branch is deployed to platta: https://kesaseteli-pr2826.api.dev.hel.ninja/healthz 🚀🚀🚀

terovirtanen · 2024-02-12T15:29:00Z

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-12T15:31:02Z

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-12T15:32:31Z

TestCafe result is success for https://tet-admin-ui-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-12T15:37:23Z

TestCafe result is success for https://helsinkilisa-ui-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-12T15:53:49Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-12T15:57:50Z

TestCafe result is success for https://helsinkilisa-ui-handler-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-12T15:58:44Z

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-12T16:01:48Z

TestCafe result is success for https://tet-youth-ui-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-13T11:29:30Z

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-13T11:34:34Z

TestCafe result is success for https://kesaseteli-employer-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-13T11:47:39Z

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-13T11:50:24Z

TestCafe result is success for https://kesaseteli-handler-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-13T12:04:33Z

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-13T12:20:08Z

TestCafe result is success for https://kesaseteli-youth-pr2826.dev.hel.ninja 😆🎉🎉🎉

sonarqubecloud · 2024-02-15T10:12:52Z

Quality Gate passed for 'yjdh-tet-shared'

Issues
43 New issues

Measures
0 Security Hotspots
42.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T10:18:53Z

Quality Gate passed for 'yjdh'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T10:19:21Z

Quality Gate passed for 'yjdh'

Issues
0 New issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T10:19:55Z

Quality Gate passed for 'yjdh'

Issues
1 New issue

Measures
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

terovirtanen · 2024-02-15T10:21:20Z

API branch is deployed to platta: https://tet-pr2826.api.dev.hel.ninja/healthz 🚀🚀🚀

sonarqubecloud · 2024-02-15T10:21:48Z

Quality Gate passed for 'yjdh'

Issues
1 New issue

Measures
0 Security Hotspots
96.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T10:21:59Z

Quality Gate passed for 'yjdh'

Issues
9 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T10:22:00Z

Quality Gate passed for 'yjdh'

Issues
5 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T10:22:40Z

Quality Gate passed for 'yjdh'

Issues
19 New issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

terovirtanen · 2024-02-15T10:22:59Z

API branch is deployed to platta: https://helsinkilisa-pr2826.api.dev.hel.ninja/healthz 🚀🚀🚀

sonarqubecloud · 2024-02-15T10:23:05Z

Quality Gate passed for 'yjdh-tet-admin'

Issues
100 New issues

Measures
0 Security Hotspots
53.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T10:23:31Z

Quality Gate passed for 'yjdh-tet-youth'

Issues
72 New issues

Measures
0 Security Hotspots
29.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T10:23:39Z

Quality Gate passed

Issues
34 New issues

Measures
0 Security Hotspots
71.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T10:25:49Z

Quality Gate passed for 'yjdh'

Issues
0 New issues

Measures
0 Security Hotspots
50.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-02-15T10:26:37Z

Quality Gate passed for 'yjdh'

Issues
8 New issues

Measures
0 Security Hotspots
84.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

terovirtanen · 2024-02-15T10:35:31Z

ADMIN branch is deployed to platta: https://tet-admin-ui-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-15T10:39:03Z

TestCafe result is success for https://tet-admin-ui-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-15T10:42:11Z

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-15T10:48:18Z

TestCafe result is success for https://helsinkilisa-ui-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-15T11:04:10Z

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-15T11:08:28Z

TestCafe result is success for https://helsinkilisa-ui-handler-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-15T11:08:50Z

YOUTH branch is deployed to platta: https://tet-youth-ui-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-15T11:11:55Z

TestCafe result is success for https://tet-youth-ui-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-15T14:05:41Z

API branch is deployed to platta: https://kesaseteli-pr2826.api.dev.hel.ninja/healthz 🚀🚀🚀

EmiliaMakelaVincit

Yeah, should be fine. I don't see a reason why this couldn't be merged if all that was changed was internal to HDS itself (lodash upgrades and internal import changes).

terovirtanen · 2024-02-15T14:19:22Z

EMPLOYER branch is deployed to platta: https://kesaseteli-employer-pr2826.dev.hel.ninja 🚀🚀🚀

karisal-anders · 2024-02-15T14:19:48Z

Yeah, should be fine. I don't see a reason why this couldn't be merged if all that was changed was internal to HDS itself (lodash upgrades and internal import changes).

Thanks, the changes between HDS v2.17.0 & v2.17.1 seem quite contained:

Removed old & deprecated individual lodash dependencies and replaced with the full package and importing the needed functions only.

terovirtanen · 2024-02-15T14:24:34Z

TestCafe result is success for https://kesaseteli-employer-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-15T14:38:25Z

HANDLER branch is deployed to platta: https://kesaseteli-handler-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-15T14:41:28Z

TestCafe result is success for https://kesaseteli-handler-pr2826.dev.hel.ninja 😆🎉🎉🎉

terovirtanen · 2024-02-15T14:57:41Z

YOUTH branch is deployed to platta: https://kesaseteli-youth-pr2826.dev.hel.ninja 🚀🚀🚀

terovirtanen · 2024-02-15T15:13:14Z

TestCafe result is success for https://kesaseteli-youth-pr2826.dev.hel.ninja 😆🎉🎉🎉

chore: update hds-(design-tokens|react)->2.17.1, unwhitelist lodash.pick

08aae5c

karisal-anders force-pushed the upgrade-to-hds-v2.17.1 branch from 485d290 to 08aae5c Compare February 12, 2024 15:02

karisal-anders changed the title ~~chore: update hds-react to 2.17.1, remove lodash.pick from audit whitelist~~ chore: update hds-(design-tokens|react)->2.17.1, unwhitelist lodash.pick Feb 12, 2024

karisal-anders requested review from sirtawast, rikuke and EmiliaMakelaVincit February 12, 2024 15:03

Merge branch 'main' into upgrade-to-hds-v2.17.1

8885051

EmiliaMakelaVincit approved these changes Feb 15, 2024

View reviewed changes

karisal-anders merged commit 00b32cf into main Feb 15, 2024
187 of 189 checks passed

karisal-anders deleted the upgrade-to-hds-v2.17.1 branch February 15, 2024 14:20

chore: update hds-(design-tokens|react)->2.17.1, unwhitelist lodash.pick #2826

chore: update hds-(design-tokens|react)->2.17.1, unwhitelist lodash.pick #2826

Conversation

karisal-anders commented Feb 12, 2024 • edited Loading

Description ✨