Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hl 1475 submitted at #3443

Merged
merged 7 commits into from
Oct 30, 2024
Merged

Hl 1475 submitted at #3443

merged 7 commits into from
Oct 30, 2024

Conversation

rikuke
Copy link
Collaborator

@rikuke rikuke commented Oct 15, 2024 •
edited
Loading

Description ✨

HL-1475
Use the submitted_at custom Application model attribute in the Ahjo payload and report csv:s,and created_at if it's not present.
HL-1362
Add an alternate, more compact csv, similar to the powerbi report, to the handler's report screen for downloading.
HL-1483
Show the alteration.recovery_amount correctly in the csv report.

Issues 🐛

Testing ⚗️

Screenshots 📸

Additional notes 🗒️

@rikuke rikuke force-pushed the HL-1475-submitted_at branch from 11469f9 to 6096bab Compare October 15, 2024 08:32
@rikuke rikuke marked this pull request as ready for review October 15, 2024 08:33
@rikuke rikuke force-pushed the HL-1475-submitted_at branch from 1ead6fa to 0979851 Compare October 18, 2024 05:44
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3443.api.dev.hel.ninja/healthz 🚀🚀🚀

1 similar comment
@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3443.api.dev.hel.ninja/healthz 🚀🚀🚀

@rikuke rikuke requested a review from sirtawast October 21, 2024 07:19
@rikuke rikuke force-pushed the HL-1475-submitted_at branch from e355229 to 80410cf Compare October 21, 2024 12:07
@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3443.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3443.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3443.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe applicant result is failed for https://helsinkilisa-ui-pr3443.dev.hel.ninja 😿💢💥💥

@terovirtanen
Copy link
Contributor

TestCafe handler result is failed for https://helsinkilisa-ui-handler-pr3443.dev.hel.ninja 😿💢💥💥

sirtawast
sirtawast previously requested changes Oct 28, 2024
View reviewed changes
backend/benefit/applications/services/applications_power_bi_csv_report.py
@@ -112,3 +111,9 @@ def CSV_COLUMNS(self):
]

return columns

def get_row_items(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this left unused?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it overrides the parent ApplicationsCsvService class method so that only one row per application is returned.

@rikuke rikuke force-pushed the HL-1475-submitted_at branch from 80410cf to b4fa2a9 Compare October 28, 2024 12:16
@sirtawast sirtawast self-requested a review October 29, 2024 08:54
@rikuke rikuke force-pushed the HL-1475-submitted_at branch from b4fa2a9 to e8957ae Compare October 29, 2024 09:08
@rikuke rikuke force-pushed the HL-1475-submitted_at branch from e8957ae to e793a49 Compare October 30, 2024 13:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
41 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.8% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
54 New issues
8 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.2% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
14 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 30, 2024

Quality Gate Passed Quality Gate passed for 'yjdh'

Issues
27 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@terovirtanen
Copy link
Contributor

API branch is deployed to platta: https://helsinkilisa-pr3443.api.dev.hel.ninja/healthz 🚀🚀🚀

@terovirtanen
Copy link
Contributor

APPLICANT branch is deployed to platta: https://helsinkilisa-ui-pr3443.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

HANDLER branch is deployed to platta: https://helsinkilisa-ui-handler-pr3443.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-pr3443.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://helsinkilisa-ui-handler-pr3443.dev.hel.ninja 😆🎉🎉🎉

@rikuke rikuke merged commit 2203360 into main Oct 30, 2024
65 checks passed
@rikuke rikuke deleted the HL-1475-submitted_at branch October 30, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirtawast sirtawast sirtawast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikuke @terovirtanen @sirtawast