Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mock data #672

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

532910
Copy link
Contributor

@532910 532910 commented Dec 9, 2024

as it is intended solely for web development and is only confusing

@roman-khimov
Copy link

@mike-petrov, how would you handle this?

@ixje
Copy link
Member

ixje commented Jan 13, 2025

I'm no TS/frontend dev, and the original author is no longer with us, so I need a bit more reason than it being confusing to remove this.

@roman-khimov
Copy link

IIUC we can have this mock data shown to users in the event of backend errors. So it'll pretend to be OK (instead of giving users some error), but in fact the data would be completely wrong. At the same time maybe this data is useful for developers that can check some UI things without a real backend.

@mike-petrov
Copy link

I think @roman-khimov are right, most likely the reason for this mock data is to test locally the web without the backend up. It also shows the backend responses well in case I just decided to look at the code on github. I don't see any practical application in production, as an option we can make a separate flag to enable mock data.

as it is intended solely for web development and is only confusing

Signed-off-by: Sergio Nemirowski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants