Skip to content
This repository has been archived by the owner on Nov 15, 2021. It is now read-only.

[re-create] Add BigInteger sanity checks for VM #676

Merged
merged 3 commits into from
Oct 20, 2018
Merged

[re-create] Add BigInteger sanity checks for VM #676

merged 3 commits into from
Oct 20, 2018

Conversation

ixje
Copy link
Member

@ixje ixje commented Oct 20, 2018

deleted old repo, re-creating PR

What current issue(s) does this address, or what feature is it adding?
Closes #566 and adds feature parity with C# on BigInteger checking: C# ref

How did you solve this problem?
write code.
Requires:
CityOfZion/neo-python-core#81
and
CityOfZion/neo-boa#106

How did you make sure your solution works?
make test and run node for a while

Are there any special changes in the code that we should be aware of?
no
Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

ixje added 3 commits October 14, 2018 15:06
* CityOfZion/development:
  stage 2 - wallet fixtures
  stage1 - Moving wallet fixtures (#675)
  Update raw TX examples to build a verifiable TX based on assets on the neo-python-privnet-unittest network (#674)
  Update neo-boa version to fix core building test
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 82.019% when pulling a69e119 on ixje:vm_biginteger into 1b6b4a0 on CityOfZion:development.

@ixje ixje merged commit 5088db5 into CityOfZion:development Oct 20, 2018
@ixje ixje deleted the vm_biginteger branch November 28, 2018 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants