Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU-86dthj1c5 - Increasing SignMessage / VerifyMessage compatibility #40

Merged
merged 4 commits into from
Jun 14, 2024
Merged

CU-86dthj1c5 - Increasing SignMessage / VerifyMessage compatibility #40

merged 4 commits into from
Jun 14, 2024

Conversation

melanke
Copy link
Contributor

@melanke melanke commented Jun 7, 2024

No description provided.

@melanke melanke requested a review from luc10921 June 7, 2024 15:05
@melanke
Copy link
Contributor Author

melanke commented Jun 7, 2024

Task linked: CU-86dthj1c5 Deep experiment with Dapi to check the difference between Neoline and NeonDappkit implementation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited
Loading

Coverage Report

Commit: 034f63c
Base: main@7b5defa

Type This PR
Total Statements Coverage  93.95%
Total Branches Coverage  81.56%
Total Functions Coverage  93.82%
Total Lines Coverage  95.03%
Details (changed files)
FileStatementsBranchesFunctionsLines
Details (all files)
FileStatementsBranchesFunctionsLines
packages/neon-dappkit/src/NeonEventListener.ts 97.95% 71.42% 100% 97.91%
packages/neon-dappkit/src/NeonInvoker.ts 87.9% 85.41% 87.5% 90.43%
packages/neon-dappkit/src/NeonParser.ts 95.74% 94.92% 96.29% 96.7%
packages/neon-dappkit/src/NeonSigner.ts 96.1% 60.71% 93.33% 96.1%
packages/neon-dappkit/src/index.ts 100% 100% 100% 100%

luc10921
luc10921 reviewed Jun 7, 2024
View reviewed changes
packages/neon-dappkit/NEON-SIGNER.md
You can use different **versions**:
1. The same format as Neoline, with salt.
2. The more readable version, easier to verify by other means (with salt).
3. The same format as Neoline, without salt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to use the SignMessageVersion enum instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@melanke melanke merged commit 6faea1e into main Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luc10921 luc10921 luc10921 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melanke @luc10921