Create user profile template

[brylie]

When migrating the old frontend templates to Django, we noticed the user profile was not rendering any content. Rather than weed through the proclaimed "horrendous code" that was responsible for rendering the BackBone view, let's just write a simple user profile template from scratch.

OpenCiviWiki/project/webapp/static/js/account.js

Lines 32 to 33 in 374381b

	// And hereon commences a pile of horrendous code. Beware!
	// TODO: review rewrite refactor. (please)

Task

• determine what fields are available on the user profile
• sketch a basic user profile page using pencil and paper or a drawing app
• discuss the proposed sketch
• implement the sketch using conventional Django elements like Form and class-based views

[devRawnie]

Here, I couldn't find any fields specified in the User model. Is there some other model, defined elsewhere?

[brylie]

We have an Account model that is basically the equivalent of a user profile:

OpenCiviWiki/project/api/models/account.py

Line 105 in 374381b

class Account(models.Model):

I propose we

1. move the Account model source code into the accounts app
2. rename the Account model to Profile
3. create a FormView for the Profile model with route
4. change front-end links to use the new 'ProfileForm` view/route

[brylie]

I opened an issue to move all accounts related code to the accounts app and rename the Account model to Profile: #926

[brylie]

This task can focus on rendering the profile edit form and should be considered a child task of #926

[wassafshahzad]

@brylie I worked on settings forms issue and this looks similar to that so could you assign it to me?
secondly should we also have a PR template ? I can create one if you could create a ticket for it an assign it to me

[brylie]

@wassafshahzad thanks for the help :-) I've assigned you to the issue.

[wassafshahzad]

@wassafshahzad thanks for the help :-) I've assigned you to the issue.

No problem always happy to help

[wassafshahzad]

@brylie would you kindly explain how will this be different from the settings form?
I could make it so that this form is readonly and clicking an edit button will redirect you to settings form.

[brylie]

@wassafshahzad good point. Let's perhaps deprecate the "user profile" form/template in favor of the settings page. I.e. just link directly to the settings page and remove any code/mention of "profile" perhaps?

[wassafshahzad]

So should i change the link from profileView to settingView ?
if possible could you explain your idea ?
Thank you

[brylie]

@wassafshahzad yes. Linking to settingView is fine for now.

[wassafshahzad]

Put up Pr for this issue.

[brylie]

Looks good. We'll merge the PR once the review comments are resolved 😃

[wassafshahzad]

Sorry I didn't add the tests yet.
Are there any more issues of priority?