Feature/update edit profile form #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good, is it possible to have some sort of basic unit testing for this new update that you are including in the project ? |
Yeah i could add test for the forms and the view . if that is ok |
|
@all-contributors please add @alanCalvillo-Wizeline for review |
|
I've put up a pull request to add @alanCalvillo-Wizeline! 🎉 |
brylie
requested changes
Sep 13, 2021
There was a problem hiding this comment.
As per @alanCalvillo-Wizeline's feedback
The code looks good, is it possible to have some sort of basic unit testing for this new update that you are including in the project ?
brylie
approved these changes
Sep 14, 2021
brylie
reviewed
Sep 14, 2021
project/threads/templates/threads/partials/account/account_base.html
Outdated
Show resolved
Hide resolved
brylie
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
What is the relevant tickets:
Closes #914
Images
